linux-kernel - RE: [PATCH] DMA Engine: fix error path(s) in fsl-dma driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <989B956029373F45A0B8AF029708189002563E31@zch01exm26.fsl.freescale.net>
Date:	Tue, 1 Jul 2008 11:38:23 +0800
From:	"Li Yang" <LeoLi@...escale.com>
To:	"Sebastian Siewior" <bigeasy@...utronix.de>
Cc:	"Zhang Wei" <zw@...kernel.org>, <linuxppc-embedded@...abs.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] DMA Engine: fix error path(s) in fsl-dma driver

> -----Original Message-----
> From: Sebastian Siewior [mailto:bigeasy@...utronix.de] 
> Sent: Tuesday, July 01, 2008 2:19 AM
> To: Li Yang
> Cc: Zhang Wei; linuxppc-embedded@...abs.org; 
> linux-kernel@...r.kernel.org
> Subject: [PATCH] DMA Engine: fix error path(s) in fsl-dma driver
> 
> of_fsl_dma_probe:
>  - kfree(NULL) doesn't hurt but dereferencing the pointer in 
> iounmap does
>  - also, the irq can be freed
> 
> of_fsl_dma_chan_probe:
> - iounmap(NULL) resolved in vunmap() what which in turn is 
> able to handle NULL
>   pointer but dereferencing still doesn't work
> - don't clean up not yet allocated ressources, like list_del 
> before list_add
> 
> fsl_dma_self_test:
> - call fsl_dma_free_chan_resources() if the first dma trans 
> didn't complete

Thanks Sebastian,

But similar patch has already been waiting in sub-system maintainer's tree which can be found at 

http://git.kernel.org/?p=linux/kernel/git/djbw/async_tx.git;a=commit;h=29ec9bdef73d68134e7070ee91ccda0718d46150

- Leo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/