linux-kernel - Re: [git pull] scheduler fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200807012236.43780.toralf.foerster@gmx.de>
Date:	Tue, 1 Jul 2008 22:36:40 +0200
From:	Toralf Förster <toralf.foerster@....de>
To:	linux-kernel@...r.kernel.org
Subject: Re: [git pull] scheduler fixes

Hello,

I've one question related to that patch:

At Tue Jul  1 22:35:30 CEST 2008 Ingo Molnar wrote :
>diff --git a/kernel/sched.c b/kernel/sched.c
>index a66e856..94ead43 100644
>--- a/kernel/sched.c
>+++ b/kernel/sched.c
>@@ -8502,6 +8502,9 @@ int sched_group_set_rt_period(struct task_group *tg, long rt_period_us)
> 	rt_period = (u64)rt_period_us * NSEC_PER_USEC;
> 	rt_runtime = tg->rt_bandwidth.rt_runtime;
> 
>+	if (rt_period == 0)
>+		return -EINVAL;
>+
> 	return tg_set_bandwidth(tg, rt_period, rt_runtime);

Why isn't the check be make before rt_runtime is set ?

-- 
MfG/Sincerely

Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

Download attachment "signature.asc " of type "application/pgp-signature" (198 bytes)