linux-kernel - Re: [PATCH] DRM/i915: only use tiled blits on 965+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.0.82.0807012140570.30359@skynet.skynet.ie>
Date:	Tue, 1 Jul 2008 21:41:30 +0100 (IST)
From:	Dave Airlie <airlied@...ux.ie>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] DRM/i915: only use tiled blits on 965+


> When scheduled swaps occur, we need to blit between front & back buffers.  If
> the buffers are tiled, we need to set the appropriate XY_SRC_COPY tile bit,
> but only on 965 chips, since it will cause corruption on pre-965 (e.g. 945).
> 
> Bug reported by and fix tested by Tomas Janousek <tomi@...i.cz>.
> 
> Signed-off-by: Jesse Barnes <jbarnes@...tuousgeek.org>

Acked-by: Dave Airlie <airlied@...ux.ie>

Linus please push for -final.

Dave.

> 
> diff --git a/drivers/char/drm/i915_irq.c b/drivers/char/drm/i915_irq.c
> index f7f16e7..df03611 100644
> --- a/drivers/char/drm/i915_irq.c
> +++ b/drivers/char/drm/i915_irq.c
> @@ -62,11 +62,11 @@ static void i915_vblank_tasklet(struct drm_device *dev)
>  	u32 ropcpp = (0xcc << 16) | ((cpp - 1) << 24);
>  	RING_LOCALS;
>  
> -	if (sarea_priv->front_tiled) {
> +	if (IS_I965G(dev) && sarea_priv->front_tiled) {
>  		cmd |= XY_SRC_COPY_BLT_DST_TILED;
>  		dst_pitch >>= 2;
>  	}
> -	if (sarea_priv->back_tiled) {
> +	if (IS_I965G(dev) && sarea_priv->back_tiled) {
>  		cmd |= XY_SRC_COPY_BLT_SRC_TILED;
>  		src_pitch >>= 2;
>  	}
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/