linux-kernel - Re: [PATCH 7/7] Fix the case of jiffies wrapping in mm/pdflush.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87od5iw8ox.fsf@devron.myhome.or.jp>
Date:	Tue, 01 Jul 2008 13:05:18 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] Fix the case of jiffies wrapping in mm/pdflush.c

Andrew Morton <akpm@...ux-foundation.org> writes:

>> @@ -151,7 +151,7 @@ static int __pdflush(struct pdflush_work
>>  		if (nr_pdflush_threads <= MIN_PDFLUSH_THREADS)
>>  			continue;
>>  		pdf = list_entry(pdflush_list.prev, struct pdflush_work, list);
>> -		if (jiffies - pdf->when_i_went_to_sleep > 1 * HZ) {
>> +		if (time_after(jiffies, pdf->when_i_went_to_sleep + 1 * HZ)) {
>>  			/* Limit exit rate */
>>  			pdf->when_i_went_to_sleep = jiffies;
>>  			break;					/* exeunt */
>
> I don't think this actually "fixes" anything, does it?  The old code
> should be correct at runtime.

Um.. Yes. It seems I tested something wrong.

> I renamed the patch to "pdflush: use time_after() instead of open-coding it".

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/