linux-kernel - Re: [PATCH] autofs4 - detect invalid direct mount requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080701141715.62a2132b.akpm@linux-foundation.org>
Date:	Tue, 1 Jul 2008 14:17:15 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ian Kent <raven@...maw.net>
Cc:	linux-kernel@...r.kernel.org, autofs@...ux.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] autofs4 - detect invalid direct mount requests

On Fri, 20 Jun 2008 13:13:03 +0800
Ian Kent <raven@...maw.net> wrote:

> autofs v5 dierct and offset mounts within an autofs filesystem are
> triggered by existing autofs triger mounts so the mount point dentry
> must be positive. If the mount point dentry is negative then the
> trigger doesn't exist so we can return fail immediately.
> 
> Signed-off-by: Ian Kent <raven@...maw.net>
> 
> ---
> 
>  fs/autofs4/waitq.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
> index cd21fd4..ae637d9 100644
> --- a/fs/autofs4/waitq.c
> +++ b/fs/autofs4/waitq.c
> @@ -307,6 +307,10 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry,
>  	if (sbi->catatonic)
>  		return -ENOENT;
>  
> +	if (!dentry->d_inode &&
> +	    (sbi->type & (AUTOFS_TYPE_DIRECT | AUTOFS_TYPE_OFFSET)))
> +		return -ENOENT;
> +
>  	name = kmalloc(NAME_MAX + 1, GFP_KERNEL);
>  	if (!name)
>  		return -ENOMEM;

A good changelog would allow little old me to determine whether this
patch should be merged into 2.6.25 and/or 2.6.26 and/or 2.6.27.  This
wasn't a good changelog :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/