linux-kernel - Re: [PATCH -mm 0/3] sysv ipc: increase msgmnb with the number of cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080701151650.f27a425a.akpm@linux-foundation.org>
Date:	Tue, 1 Jul 2008 15:16:50 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	<Solofo.Ramangalahy@...l.net>
Cc:	linux-kernel@...r.kernel.org, matthltc@...ibm.com, cmm@...ibm.com,
	Nadia.Derbey@...l.net, manfred@...orfullife.com,
	nickpiggin@...oo.com.au
Subject: Re: [PATCH -mm 0/3] sysv ipc: increase msgmnb with the number of
 cpus

On Tue, 24 Jun 2008 11:34:52 +0200
<Solofo.Ramangalahy@...l.net> wrote:

> The size in bytes of a SysV IPC message queue, msgmnb, is too small
> for large machines, but we don't want to bloat small machines.
> 
> This series change ("scale") the default value of
> /proc/sys/kernel/msgmnb.

I'm afraid I've lost track of what's happening here.  Did we come up
with an alternative to "magical positive-versus-negative number trick"?

Your patch #1 adds and uses recompute_msgmnb() without adding the
declaration to a header file.  Your patch #2 does add the
recompute_msgmnb() to a header file, so we have a window in which the
build is broken, which is bad.

recompute_msgmnb() isn't a terribly good globally-visible identifier,
btw.  It is nice to add some subsystem identifer as a prefix.  There's
little chance of this symbol colliding with anything else, so this is a
minor cosmetic thing in this case.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/