linux-kernel - Re: [PATCH] Add base_hi BAR for oxsemi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080702002421.084d4f1c@kopernikus.site>
Date:	Wed, 2 Jul 2008 00:24:21 +0200
From:	Bernhard Walle <bwalle@...e.de>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add base_hi BAR for oxsemi_840

* Andrew Morton <akpm@...ux-foundation.org> [2008-07-01 15:00]:
> > 
> > --- a/drivers/parport/parport_pc.c
> > +++ b/drivers/parport/parport_pc.c
> > @@ -2877,7 +2877,7 @@ static struct parport_pc_pci {
> >  	 * and 840 locks up if you write 1 to bit 2! */
> >  	/* oxsemi_952 */		{ 1, { { 0, 1 }, } },
> >  	/* oxsemi_954 */		{ 1, { { 0, -1 }, } },
> > -	/* oxsemi_840 */		{ 1, { { 0, -1 }, } },
> > +	/* oxsemi_840 */		{ 1, { { 0, 1 }, } },
> >  	/* aks_0100 */                  { 1, { { 0, -1 }, } },
> >  	/* mobility_pp */		{ 1, { { 0, 1 }, } },
> >  	/* netmos_9705 */               { 1, { { 0, -1 }, } }, /* untested */
> 
> My parport knowledge doesn't permit me to understand how serious the
> just-fixed bug was.  Non-functional parport?
> 
> If so, this looks like a 2.6.26 and 2.6.25.x fix?

No, for good old printers, everything works. It's just that ECR
register was not available (the base_hi stuff). Because of that,
the TRISTATE detection did not work, which meant that for me my
self-built logic analyzer which uses the parallel port did not work.

Just merge in 2.6.27 is enough. :)


Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/