linux-kernel - Re: [PATCH 5/23] make section names compatible with -ffunction-sections -fdata-sections: blackfin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0807011558u2c02f6fcre2f3af3d5cced936@mail.gmail.com>
Date:	Tue, 1 Jul 2008 18:58:02 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Denys Vlasenko" <vda.linux@...glemail.com>
Cc:	linux-arch@...r.kernel.org, "Russell King" <rmk@....linux.org.uk>,
	"David Howells" <dhowells@...hat.com>,
	"Ralf Baechle" <ralf@...ux-mips.org>,
	"Lennert Buytenhek" <kernel@...tstofly.org>,
	"Josh Boyer" <jwboyer@...ux.vnet.ibm.com>,
	"Paul Mackerras" <paulus@...ba.org>,
	"David Woodhouse" <dwmw2@...radead.org>,
	"Andi Kleen" <andi@...stfloor.org>, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org,
	"Paul Gortmaker" <paul.gortmaker@...driver.com>,
	linux-embedded@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Tim Bird" <tim.bird@...sony.com>,
	"Martin Schwidefsky" <schwidefsky@...ibm.com>,
	"Dave Miller" <davem@...emloft.net>
Subject: Re: [PATCH 5/23] make section names compatible with -ffunction-sections -fdata-sections: blackfin

On Tue, Jul 1, 2008 at 8:35 PM, Denys Vlasenko wrote:
> The purpose of this patch is to make kernel buildable
> with "gcc -ffunction-sections -fdata-sections".
> This patch fixes blackfin architecture.

the comment right above what you changed says it already works for
Blackfin.  so you arent fixing it at all.
>                /* This gets done first, so the glob doesn't suck it in */
>                . = ALIGN(32);
> -               *(.data.cacheline_aligned)
> +               *(.cacheline_aligned.data)

ive built Blackfin kernels with function/data sections a long time ago
... but iirc, there were toolchain problems, so i havent pursued it
since.

if you're going to muck with names, you might as well do it right the
first time: move the names into asm-generic/vmlinux.lds.h so we dont
have to worry about this kind of churn again.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/