linux-kernel - Re: [patch] security: fix dummy xattr functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Xine.LNX.4.64.0807021906350.26138@us.intercode.com.au>
Date:	Wed, 2 Jul 2008 19:16:40 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Miklos Szeredi <miklos@...redi.hu>
cc:	jjohansen@...e.de, akpm@...ux-foundation.org,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, serue@...ibm.com, morgan@...nel.org
Subject: Re: [patch] security: fix dummy xattr functions

On Wed, 2 Jul 2008, Miklos Szeredi wrote:

> So where do the dummy_ functions figure into this?  As I understand,
> they are called whenever LSM is disabled, but the LSM doesn't define a
> particular hook, so there's a default implementation.  Is that correct?

If LSM is disabled, nothing is called (the security hooks are optimized 
away).  It's for when LSM is enabled, but there is either no LSM module 
selected, or as fallbacks for hooks which are not implemented by an LSM 
module.

> If so, then in theory it is still theoretically possible that with
> LSM+capabilities, the LSM doesn't explicitly stack inode_setxattr and
> inode_removexattr, and so the dummy implementation should do that
> instead.  What am I missing?

The LSM is responsible for performing this stacking (or not), depending on 
which particular security models are desired.  It may, for example, not 
want filesystem capabilities.

I guess it might be safer to force the LSM to override fs capabilities if 
it doesn't want them, but I'd like to see what others think.

- James
-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/