linux-kernel - [resend][PATCH] fix lru_cache_add_active_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20080702221101.D16A.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Wed, 02 Jul 2008 22:19:24 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	LKML <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rik van Riel <riel@...hat.com>,
	Lee Schermerhorn <Lee.Schermerhorn@...com>
Cc:	kosaki.motohiro@...fujitsu.com
Subject: [resend][PATCH] fix lru_cache_add_active_or_unevictable

I found I forgot insert below patch to my patchset for 2.6.26-rc5-mm3 today.
So, I resend it.

enjoy!


-------------------------
From: Rik van Riel <riel@...hat.com>

Undo an overzealous code cleanup to lru_cache_add_active_or_unevictable.
The callers do not set PageActive so the page would get added to the
wrong list.

Signed-off-by: Rik van Riel <riel@...hat.com>
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>

Index: linux-2.6.26-rc5-mm3/mm/swap.c
===================================================================
--- linux-2.6.26-rc5-mm3.orig/mm/swap.c	2008-07-01 18:47:04.000000000 +0900
+++ linux-2.6.26-rc5-mm3/mm/swap.c	2008-07-01 19:28:43.000000000 +0900
@@ -259,7 +259,7 @@
 					struct vm_area_struct *vma)
 {
 	if (page_evictable(page, vma))
-		lru_cache_add_lru(page, page_lru(page));
+		lru_cache_add_lru(page, LRU_ACTIVE + page_is_file_cache(page));
 	else
 		add_page_to_unevictable_list(page);
 }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/