linux-kernel - Re: [PATCH] mfd: fix a bug in the asic3 irq demux code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080702182219.GB15015@caravaggio>
Date:	Wed, 2 Jul 2008 20:22:20 +0200
From:	Samuel Ortiz <sameo@...nedhand.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Philipp Zabel <philipp.zabel@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: fix a bug in the asic3 irq demux code

Hi Andrew,

On Wed, Jul 02, 2008 at 10:53:03AM -0700, Andrew Morton wrote:
> On Wed, 02 Jul 2008 19:42:53 +0200 Philipp Zabel <philipp.zabel@...il.com> wrote:
> 
> > Wrong irq numbers were given to desc->handle_irq, which
> > on some devices caused endless loops (asic3_irq_demux
> > calling itself, basically).
> > 
> > Signed-off-by: Philipp Zabel <philipp.zabel@...il.com>
> > ---
> >  drivers/mfd/asic3.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
> > index 8e41130..59ec9c6 100644
> > --- a/drivers/mfd/asic3.c
> > +++ b/drivers/mfd/asic3.c
> > @@ -308,7 +308,7 @@ static void asic3_irq_demux(unsigned int irq, struct irq_desc *desc)
> >  		for (i = ASIC3_NUM_GPIOS; i < ASIC3_NR_IRQS; i++) {
> >  			/* They start at bit 4 and go up */
> >  			if (status & (1 << (i - ASIC3_NUM_GPIOS + 4))) {
> > -				desc = irq_desc +  + i;
> > +				desc = irq_desc + asic->irq_base + i;
> >  				desc->handle_irq(asic->irq_base + i,
> >  						 desc);
> >  			}
> 
> hm, I seem to have a pile of mfd patches.  I'll look to offload those
> on Samuel.
> 
> Samuel, will you be setting up an MFD git tree for linux-next?  (You
> should, please).
I have set up an mfd tree here: http://git.o-hand.com/?r=linux-mfd
with a for-next branch. I havent asked Stephen to pull from it yet,
and I havent Cc'ed you on the mfd patches that are sitting there as
I was mostly setting things up. I will clean things up and re-apply
them so that you get a notification for all the mfd patches that are
already on -mm.

I also requested for an account on kernel.org, but I'm still waiting
for an answer.

Cheers,
Samuel.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/