linux-kernel - Re: [PATCH] drivers/net/wireless/iwlwifi/iwl-3945.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080702192457.GB31288@tuxdriver.com>
Date:	Wed, 2 Jul 2008 15:24:57 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Darren Jenkins <darrenrjenkins@...il.com>
Cc:	kernel Janitors <kernel-janitors@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	ipw2100-admin@...ux.intel.com, yi.zhu@...el.com,
	reinette.chatre@...el.com
Subject: Re: [PATCH]  drivers/net/wireless/iwlwifi/iwl-3945.c

What about the format line in the IWL_DEBUG_RX that uses rate?

Also, please use an email subject that is more descriptive than just
the filename.  You should probably drop the "G'day..." line as well.

Thanks!

John

On Wed, Jul 02, 2008 at 11:37:27AM +1000, Darren Jenkins" wrote:
> G'day people
> 
> Coverity CID: 2265 NEGATIVE_RETURNS
> 
> "rate" is of an unsigned type, and the code requires a signed type.
> The following patch makes it so.
> 
> Only compile tested.
> 
> Signed-off-by: Darren Jenkins <darrenrjenkins@...ilcom>
> 
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> index 62a3d8f..31d38cd 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -449,7 +449,7 @@ static void iwl3945_dbg_report_frame(struct iwl3945_priv *priv,
>  
>  	if (print_summary) {
>  		char *title;
> -		u32 rate;
> +		int rate;
>  
>  		if (hundred)
>  			title = "100Frames";
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
John W. Linville
linville@...driver.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/