linux-kernel - Re: [PATCH] PalmTX initial support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807030053.00019.marek.vasut@gmail.com>
Date:	Thu, 3 Jul 2008 00:52:59 +0200
From:	Marek Vasut <marek.vasut@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Ben Dooks <ben-linux@...ff.org>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.arm.linux.org.uk
Subject: Re: [PATCH] PalmTX initial support

ok, I fixed what I was able to grasp. That is :

-Are these useful? + Dittos
-Don't you have to configure GPIO47 as a GPIO to change its state?
Since you don't, and I assume you've tested this, I think you've
proven that you can delete the fiddling with GPIO47.

Actually GPIO47 was set up before by palmos (since Im not booting from clean 
state, but from palmOS) so it wasnt necessary to set it up again in linux and 
it didnt cause any problems. Booting it from clean state would cause 
problems, so I fixed it.

-I belive these calls are being deprecated.
-don't call set_irq_type, pass the relevant trigger flags to
request_irq().
-I've never seen the pooint of #ifdefs for platform data, just bung
the lot in, it is always possible to build and an insert a new driver
module to support this after building the zImage.
-hmm, real email addresses are generally safe here.
-aren't there some gpio defines to actually define these to?

Yea, I threw away all the remaining redefined GPIOs

That's it, but what I still dont understand is the pxa branch (and new PWM 
stuff). Im currently using mainline (linus's tree), so that's not the tree I 
should use ?

View attachment "palmtx-ml-v2.patch" of type "text/x-diff" (13629 bytes)