linux-kernel - Re: [PATCH 1/1] x86: Add check for node passed to node_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19f34abd0807030155x22b0033dj780830bad840216f@mail.gmail.com>
Date:	Thu, 3 Jul 2008 10:55:34 +0200
From:	"Vegard Nossum" <vegard.nossum@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Mike Travis" <travis@....com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	mm-commits@...r.kernel.org, "Yinghai Lu" <yhlu.kernel@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] x86: Add check for node passed to node_to_cpumask V3

On Thu, Jul 3, 2008 at 10:44 AM, Ingo Molnar <mingo@...e.hu> wrote:
>
> * Mike Travis <travis@....com> wrote:
>
>> Subject: [PATCH 1/1] x86: Add check for node passed to node_to_cpumask V3
>>
>>   * When CONFIG_DEBUG_PER_CPU_MAPS is set, the node passed to
>>     node_to_cpumask and node_to_cpumask_ptr should be validated.
>>     If invalid, then a dump_stack is performed and a zero cpumask
>>     is returned.
>>
>> Based on "Fri Jun 27 10:06:06 PDT 2008" tip/master...  ;-)
>>
>> Signed-off-by: Mike Travis <travis@....com>
>> ---
>> V2: Slightly different version to remove a compiler warning.
>> V3: Redone to reflect moving setup.c -> setup_percpu.c
>
> applied to tip/x86/unify-setup - thanks Mike.
>
> Vegard, can i add your Acked-by too?

To be honest, I'd prefer that the function returns a const pointer.
Mike and I have both reviewed all callers independently and concluded
that there is no problem in doing this, and that, in fact, this is the
correct way to deal with it.

So if Mike submits a V4 with this const return type, or another patch
on top of this one, I'll ack it :-)


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/