linux-kernel - Re: [mmotm] build failure on x86_64 pci-calgary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080703090722.GA17350@elte.hu>
Date:	Thu, 3 Jul 2008 11:07:22 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	Li Zefan <lizf@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, npiggin@...e.de,
	Lee Schermerhorn <Lee.Schermerhorn@...com>,
	Rik Van Riel <riel@...hat.com>
Subject: Re: [mmotm] build failure on x86_64 pci-calgary_64.c


* KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:

> > > Seems the problematic patch is :
> > > mmap-handle-mlocked-pages-during-map-remap-unmap.patch
> > > 
> > > I'm using mmotm uploaded yesterday by Andrew, so I guess this bug
> > > has not been fixed ?
> > > 
> > > BUG: sleeping function called from invalid context at include/linux/pagemap.h:290
> > > in_atomic():1, irqs_disabled():0
> > 
> > sorry for that.
> > I started investigate this problem.
> 
> Hi Andrew,
> 
> on ia64, I can't reproduce this problem.
> on x86_64, I can't build kernel because following error happned.
>            (end_pfn doesn't exist, but used)
> 
> 
> -----------------------------------------------------
> % LANG=C make -j 20
>   CHK     include/linux/version.h
>   CHK     include/linux/utsrelease.h
>   CALL    scripts/checksyscalls.sh
>   CHK     include/linux/compile.h
>   CC      arch/x86/kernel/pci-calgary_64.o
> arch/x86/kernel/pci-calgary_64.c: In function 'detect_calgary':
> arch/x86/kernel/pci-calgary_64.c:1413: error: 'end_pfn' undeclared (first use in this function)
> arch/x86/kernel/pci-calgary_64.c:1413: error: (Each undeclared identifier is reported only once
> arch/x86/kernel/pci-calgary_64.c:1413: error: for each function it appears in.)
> make[1]: *** [arch/x86/kernel/pci-calgary_64.o] Error 1
> make: *** [arch/x86/kernel] Error 2
> make: *** Waiting for unfinished jobs....
> make: *** wait: No child processes.  Stop.
> 
> -----------------------------------------------------
> 
> 
> I guess below commit or related commit is doubtfully.
> 
> :commit 1b1b18f0bf62ec808784002382f2b5833701afda
> :Author: Yinghai Lu <yhlu.kernel@...il.com>
> :Date:   Tue Jun 24 22:14:09 2008 -0700
> :
> :    x86: remove end_pfn in 64bit
> :
> :    and use max_pfn directly.
> :
> :    Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>
> :    Signed-off-by: Ingo Molnar <mingo@...e.hu>

no.

this a linux-next integration artifact AFAICT, there's no such build 
failure in the x86 tree.

what happened is that the x86 tree got rid of end_pfn, the PCI tree grew 
one more reference to it and it was not fixed up.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/