linux-kernel - Re: [Bug 10868] Oops on loading ipaq module since 2.6.26, prevents use of device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080703150000.GD11254@cs181140183.pp.htv.fi>
Date:	Thu, 3 Jul 2008 18:00:00 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	Oliver Neukum <oliver@...kum.org>
Cc:	Adam Williamson <awilliamson@...driva.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Arjan van de Ven <arjan@...radead.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...hat.com>, bugme-daemon@...zilla.kernel.org,
	Greg KH <greg@...ah.com>, linux-usb@...r.kernel.org,
	Matthias Geissert <matthias.geissert@....de>
Subject: Re: [Bug 10868] Oops on loading ipaq module since 2.6.26, prevents
	use of device

On Thu, Jul 03, 2008 at 04:26:48PM +0200, Oliver Neukum wrote:
> Am Donnerstag 03 Juli 2008 16:20:30 schrieb Adrian Bunk:
> > On Thu, Jul 03, 2008 at 04:08:44PM +0200, Oliver Neukum wrote:
> > > Am Donnerstag 03 Juli 2008 10:57:33 schrieb Adrian Bunk:
> 
> > > > --- a/drivers/usb/serial/ipaq.c
> > > > +++ b/drivers/usb/serial/ipaq.c
> > > > @@ -571,9 +571,9 @@ static struct usb_serial_driver ipaq_device = {
> > > >  	.usb_driver = 		&ipaq_driver,
> > > >  	.id_table =		ipaq_id_table,
> > > >  	.num_interrupt_in =	NUM_DONT_CARE,
> > > > -	.num_bulk_in =		1,
> > > > -	.num_bulk_out =		1,
> > > > -	.num_ports =		1,
> > > > +	.num_bulk_in =		NUM_DONT_CARE,
> > > > +	.num_bulk_out =		NUM_DONT_CARE,
> > > 
> > > This is good.
> > 
> > These fields are removed by a later commit in 2.6.26...  8-)
> 
> Well, NUM_DONT_CARE is default, so it makes no difference, but a comment
> would have been nice.

They were removed from struct usb_serial_driver in 
include/linux/usb/serial.h since the checks they were used for caused 
more problems than they solved.

But you are right that the effects of the removal are the same as 
NUM_DONT_CARE.

> 	Regards
> 		Oliver

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/