linux-kernel - RE: [PATCH 1/3] AMD Family10h+ IBS support for oProfile driver:Setup routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6096959DEF5C9447A6BF80BDC7EB9EDC08650AB3@SBOSEXMB1.amd.com>
Date:	Thu, 3 Jul 2008 11:36:42 -0400
From:	"Kasindorf, Barry" <Barry.Kasindorf@....com>
To:	"Ingo Molnar" <mingo@...e.hu>,
	"Andrew Morton" <akpm@...ux-foundation.org>
CC:	<linux-kernel@...r.kernel.org>,
	"Richter, Robert" <rrichter@...e.amd.com>,
	"the arch/x86 maintainers" <x86@...nel.org>,
	"Stephane Eranian" <eranian@...il.com>,
	"Yeh, Jason" <jason.yeh@....com>,
	"Arjan van de Ven" <arjan@...radead.org>,
	"Markus Metzger" <markus.t.metzger@...el.com>
Subject: RE: [PATCH 1/3] AMD Family10h+ IBS support for oProfile driver:Setup routines

I have re-worked the IBS patchset and will break it into smaller pieces
and re-submit it RSN.
I will rebase it against -mm or Linux-next whichever is best. I need
Robert's AMD Family10h EPCI patches for this to build so that has to
already be there in whichever tree I use.
This patchset does interact with Jason's multiplexing changes but we can
work that out.
-Barry


-----Original Message-----
From: Ingo Molnar [mailto:mingo@...e.hu] 
Sent: Thursday, July 03, 2008 6:01 AM
To: Andrew Morton
Cc: Kasindorf, Barry; linux-kernel@...r.kernel.org; Richter, Robert; the
arch/x86 maintainers; Stephane Eranian; Yeh, Jason; Arjan van de Ven;
Markus Metzger
Subject: Re: [PATCH 1/3] AMD Family10h+ IBS support for oProfile
driver:Setup routines


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Thu, 3 Jul 2008 11:20:52 +0200 Ingo Molnar <mingo@...e.hu> wrote:
> 
> > 1) please rebase your patches ontop of -mm, which carries the 
> > oprofile multiplexing cleanups and enhancements already which 
> > heavily interact with your patchset.
> 
> I dropped those.  Because it's obvious that significant changes are to

> be made.  So I guess working against linux-next is appropriate for 
> this change.

hm, okay. All the pending oprofile enhancements are nice in principle 
and there's like 3-4 oprofile topics that we should really start 
reviewing, integrating and testing:

- the gist of the perfmon2 changes which make oprofile work across
  context-switches. Oprofile should have done this from the get go.

- the oprofile syscall enhancements from perfmon2 for lightning-fast
  profiling feedback.

- oprofile multiplexing: makes hw counter constraints largely invisible.
  Should have been done years ago.

- new hw support like this IBS patch but it would also be nice to see
  BTS/PEBS support perhaps.

- [ personally i'd love to see /debug/oprofile/prof.txt that would do
    user-space-less parsing of oprofile data and would in essence 
    replace readprofile for all practical purposes. (while still being 
    as simple and self-contained as readprofile) Full in-kernel 
    generation of human-readable text output. This would be the thing
    that would bring oprofile a lot closer to the average kernel 
    developer IMO. (Also, various knobs under /debug/oprofile/* to
    configure oprofile details on the fly, without any userspace 
    dependencies.) ]

- [ oprofile .config driven in-kernel self-tests. Right now we notice it

    quite late when it breaks. If we do /debug/oprofile/ that would be a

    great step towards that. ]

tip/x86/oprofile (which already has some smaller changes) could host 
them, if there's interest. It would be renamed to tip/oprofile or so, 
kept separate and exported separately for import into -mm and/or 
linux-next - not mixed into x86 and other -tip bits.

v2.6.28 stuff at the earliest, obviously.

	Ingo


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/