lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 Jul 2008 11:12:24 +0200 From: Haavard Skinnemoen <haavard.skinnemoen@...el.com> To: Dmitry Baryshkov <dbaryshkov@...il.com> Cc: Ben Dooks <ben-linux@...ff.org>, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, Russell King <rmk+lkml@....linux.org.uk>, Paul Mundt <lethal@...ux-sh.org>, pHilipp Zabel <philipp.zabel@...il.com>, Pavel Machek <pavel@....cz>, tony@...mide.com, paul@...an.com, David Brownell <david-b@...bell.net>, Mark Brown <broonie@...nsource.wolfsonmicro.com>, ian <spyro@....com> Subject: Re: [PATCH 1/3] Clocklib: add generic framework for managing clocks. Dmitry Baryshkov <dbaryshkov@...il.com> wrote: > > > +#ifdef CONFIG_DEBUG_FS > > > + struct dentry *dir; > > > + struct dentry *info; > > > +#endif > > > > Can't you hide this in the code, say by wrappering the > > struct with something else when it is registered? > > It is allocated dynamically by drivers. I can move this to > struct clk_private to specify that it's private, but it should be > visible outside Actually, I don't think it _should_ be private. Low-level clock drivers might want to provide debugfs nodes on their own, and those nodes naturally belong in the same directory as the clklib ones. So the debugfs root node must be exposed somehow. You can get rid of the "info" field if you apply this patch: http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/driver-core/debugfs-implement-debugfs_remove_recursive.patch Haavard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists