linux-kernel - Re: [PATCH] fix build error of driver/mfd/tc6393xb.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807040950.17877.david-b@pacbell.net>
Date:	Fri, 4 Jul 2008 09:50:17 -0700
From:	David Brownell <david-b@...bell.net>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Dmitry Baryshkov <dbaryshkov@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fix build error of driver/mfd/tc6393xb.c

On Friday 04 July 2008, Takashi Iwai wrote:
> 
> > The proper fix probably is to make PPC_MPC5200_GPIO also select
> > GENERIC_GPIO.

I think it's higher in the dependency tree than that.

> > I don't think that building GPIO_LIB w/o GENERIC_GPIO 
> > should be supported.
> 
> [Added David to Cc]
> 
> Then HAVE_GPIO_LIB should depend on GENERIC_GPIO.

They must go together ... right.  Anything using gpiolib
without the interface it implements needs a head-exam. ;)

But since ISTR that Kconfig (still) doesn't get dependencies
right when you "select" something that depends on something
else, that particular solution won't fly.

> Or, linux/gpio.h should be fixed so that the code can be built
> properly without GENERIC_GPIO.

No; GENERIC_GPIO is the interface, HAVE_GPIO_LIB is one
of the valid ways to implement it.

It should work if HAVE_GPIO_LIB selected GENERIC_GPIO...

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/