lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 5 Jul 2008 02:18:49 +0900
From:	"Akinobu Mita" <akinobu.mita@...il.com>
To:	"James Bottomley" <James.Bottomley@...senpartnership.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	"Brian King" <brking@...ibm.com>
Subject: Re: [PATCH -mm] fix ipr-use-memory_read_from_buffer.patch

>> --- 2.6-mm.orig/drivers/scsi/ipr.c
>> +++ 2.6-mm/drivers/scsi/ipr.c
>> @@ -71,6 +71,7 @@
>>  #include <linux/module.h>
>>  #include <linux/moduleparam.h>
>>  #include <linux/libata.h>
>> +#include <linux/string.h>
>>  #include <asm/io.h>
>>  #include <asm/irq.h>
>>  #include <asm/processor.h>
>
> This isn't really necessary, is it?  As you can see from the file being
> stuffed full of memcpy directives, it's already getting an implicit
> include of string.h from somewhere (like the rest of the SCSI drivers).

Indeed. This is not necessary.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists