linux-kernel - Re: [PATCH -rt] [resend as inlined patch] {queue,schedule}_work_prio() allowing work priorities other than caller's priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1215193280.9513.3.camel@localhost.localdomain>
Date:	Fri, 04 Jul 2008 10:41:20 -0700
From:	Daniel Walker <dwalker@...sta.com>
To:	Leon Woestenberg <leon.woestenberg@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	RT <linux-rt-users@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>, leon@...ebranch.com
Subject: Re: [PATCH -rt] [resend as inlined patch]
	{queue,schedule}_work_prio() allowing work priorities other than caller's
	priority


On Fri, 2008-07-04 at 15:35 +0200, Leon Woestenberg wrote:

> Index: linux-2.6.24/kernel/workqueue.c
> ===================================================================
> --- linux-2.6.24.orig/kernel/workqueue.c    2008-06-30 
> 17:12:05.000000000 +0200
> +++ linux-2.6.24/kernel/workqueue.c    2008-06-30 17:25:03.000000000 +0200
> @@ -163,9 +163,10 @@
>  }
>  
>  /**
> - * queue_work - queue work on a workqueue
> + * queue_work_prio - queue work on a workqueue and set work priority
>   * @wq: workqueue to use
>   * @work: work to queue
> + * @prio: priority of work
>   *
>   * Returns 0 if @work was already on a queue, non-zero otherwise.
>   *
> @@ -174,17 +175,36 @@
>   *
>   * Especially no such guarantee on PREEMPT_RT.
>   */
> -int fastcall queue_work(struct workqueue_struct *wq, struct work_struct 
> *work)
> +int fastcall queue_work_prio(struct workqueue_struct *wq,
> +  struct work_struct *work, int prio)

Looks like you patch has line wrapped damage, and white space damage..
If your cutting an pasting the patches that will usually remove the
white space (which we don't want), and often mailers will line wrap if
you don't specify that it's formatted already.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/