linux-kernel - Re: [PATCH] ieee1394 : dump mmapped video1394 buffers in core files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <486E6CED.8060309@s5r6.in-berlin.de>
Date:	Fri, 04 Jul 2008 20:33:17 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Philippe De Muyter <phdm@...qel.be>
CC:	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ieee1394 : dump mmapped video1394 buffers in core files

Philippe De Muyter wrote:
> Currently, core files do not contain the mmapped memory of the video1394
> or dv1394 devices,

Ditto with /dev/raw1394 when the rawiso ioctl API is used.

> which contain the actual video input, making it
> impossible to analyse the cause of abnormal program termination for
> image analysis or (de)compression software.  Fix that.
> 
> Signed-off-by: Philippe De Muyter <phdm@...qel.be>
> ---
> diff -r ced66ca0044f drivers/ieee1394/dma.c
> --- a/drivers/ieee1394/dma.c	Mon Jun 30 08:58:09 2008 -0700
> +++ b/drivers/ieee1394/dma.c	Thu Jul  3 18:40:24 2008 +0200
> @@ -274,7 +274,7 @@ int dma_region_mmap(struct dma_region *d
>  	vma->vm_ops = &dma_region_vm_ops;
>  	vma->vm_private_data = dma;
>  	vma->vm_file = file;
> -	vma->vm_flags |= VM_RESERVED;
> +	vma->vm_flags |= VM_RESERVED | VM_ALWAYSDUMP;
>  
>  	return 0;
>  }

I'll commit it with the title changed to "dump mmapped iso buffers in 
core files" if that's OK.
-- 
Stefan Richter
-=====-==--- -=== --=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/