| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080705115451.GC5454@osiris.boeblingen.de.ibm.com> Date: Sat, 5 Jul 2008 13:54:51 +0200 From: Heiko Carstens <heiko.carstens@...ibm.com> To: Johannes Weiner <hannes@...urebad.de> Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org Subject: Re: [PATCH 02/20] lib: generic show_mem() > > Umh.. I think your 4th patch set was the way to go. This set is not > > bisectable anymore and those architectures which you didn't convert > > to the generic implementation won't build anymore. show_mem is present > > twice there... > > hannes@...scraper:/tmp/test$ gcc -o prog prog.c lib1.a lib2.a && ./prog > lib1 > hannes@...scraper:/tmp/test$ gcc -o prog prog.c lib2.a lib1.a && ./prog > lib2 > > Both lib1 and lib2 define foo() which prog calls. > > I tested this with x86 and it built before and after removal of the > x86-specific show_mem() (and it did the right thing as the arch code has > higher priority than lib code). > > But why is it no more bisectable? You have one point where your kernel > uses the arch-specific show_mem() and in the next commit, you use the > generic version. If something breaks, you can compare the old arch > version with the generic version. My fault. It works. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists