linux-kernel - Re: [PATCH] dsp56k: use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1215357224.2817.2.camel@jaswinder.satnam>
Date:	Sun, 06 Jul 2008 20:43:44 +0530
From:	Jaswinder Singh <jaswinder@...radead.org>
To:	Fredrik Noring <noring@...rew.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	David Woodhouse <dwmw2@...radead.org>,
	kernelnewbies <kernelnewbies@...linux.org>,
	kernel-janitors <kernel-janitors@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>, lars@...rew.org,
	tomas@...rew.org
Subject: Re: [PATCH] dsp56k: use request_firmware

Hello Fredrik,

On Sun, 2008-07-06 at 15:36 +0200, Fredrik Noring wrote:
> Hi Jaswinder,
> 
> 5 jul 2008 kl. 12.24 skrev Jaswinder Singh:
> > +	for (i = 0; i < fw->size; i + 3) {
> 
> Are you sure about "i + 3" in this loop? Isn't GCC complaining,  
> something like "statement with no effect"?
> 

Fixed, Thanks.

> > +Driver: ATARI_DSP56K - Atari DSP56k support
> > +
> > +File: dsp56k/bootstap.bin
> > +
> > +Licence: Unknown
> > +
> > +Found in hex form in kernel source.
> 
> I wrote this DSP56k assembler code in 1995. It's a trivial copy loop  
> that loads the main DSP program into memory. Please consider it GPL  
> like the driver code it came from.
> 
> A disassembler would easily recreate the original ~50 lines of  
> assembler source code, in case you'd like to assemble it with the rest  
> of kernel. :)
> 

Fixed.

Updated patch :
http://git.infradead.org/users/jaswinder/firm-jsr-2.6.git?a=commitdiff;h=4f5b8828113ea857a7b590b7dbb8a5ee78103de4

Thanks for you comments.

Thank you,

Jaswinder Singh.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/