linux-kernel - Re: [PATCH] dsp56k: use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1215363247.3189.113.camel@shinybook.infradead.org>
Date:	Sun, 06 Jul 2008 17:54:07 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Jaswinder Singh <jaswinder@...radead.org>
Cc:	Fredrik Noring <noring@...rew.org>,
	LKML <linux-kernel@...r.kernel.org>,
	kernelnewbies <kernelnewbies@...linux.org>,
	kernel-janitors <kernel-janitors@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>, lars@...rew.org,
	tomas@...rew.org
Subject: Re: [PATCH] dsp56k: use request_firmware

On Sun, 2008-07-06 at 21:08 +0530, Jaswinder Singh wrote:
> Hello Fredrik,
> 
> On Sun, 2008-07-06 at 17:36 +0200, Fredrik Noring wrote:
> > Hi Jaswinder,
> > 
> > 6 jul 2008 kl. 17.13 skrev Jaswinder Singh:
> > > Updated patch :
> > > http://git.infradead.org/users/jaswinder/firm-jsr-2.6.git?a=commitdiff;h=4f5b8828113ea857a7b590b7dbb8a5ee78103de4


+Licence: GPL
+Assembly Source Code of ~50 lines can be generated by disassemble

Shouldn't that be 'GPLv2'? 

And it's better just to say '...but original assembler source code lost'
than to point say that it can be disassembled.

It would be better still to dig out a DSP56001 disassembler and actually
disassemble it. Why don't you do that?

> > > Thanks for you comments.
> > 
> > Excellent. (Unfortunately I don't have access to the hardware to test  
> > these changes.)
> 
> Please test this and let us know the result.

He said he can't.

> Please upload assembly code with Licence on Net so that I can point
> Assembly Source code in firmware/WHENCE.

I don't think he has it. That's why he suggested a disassembler.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/