linux-kernel - Re: [PATCH] workqueues: lockdep annotations for flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080706173538.GA2500@ami.dom.local>
Date:	Sun, 6 Jul 2008 19:35:38 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Jarek Poplawski <jarkao2@...pl>,
	Johannes Berg <johannes@...solutions.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] workqueues: lockdep annotations for flush_work()

On Sun, Jul 06, 2008 at 08:28:00PM +0400, Oleg Nesterov wrote:
> Add lockdep annotations to flush_work() and update the comment.
> 
> Signed-off-by: Oleg Nesterov <oleg@...sign.ru>

Looks OK to me. (But probably the comment on "true" would be easier
(more precise).)

Regards,
Jarek P.

> 
> --- 26-rc2/kernel/workqueue.c~FW_LOCKDEP	2008-06-29 19:36:27.000000000 +0400
> +++ 26-rc2/kernel/workqueue.c	2008-07-06 20:15:16.000000000 +0400
> @@ -403,6 +403,8 @@ EXPORT_SYMBOL_GPL(flush_workqueue);
>   * flush_work - block until a work_struct's callback has terminated
>   * @work: the work which is to be flushed
>   *
> + * Returns false if @work has already terminated.
> + *
>   * It is expected that, prior to calling flush_work(), the caller has
>   * arranged for the work to not be requeued, otherwise it doesn't make
>   * sense to use this function.
> @@ -418,6 +420,9 @@ int flush_work(struct work_struct *work)
>  	if (!cwq)
>  		return 0;
>  
> +	lock_acquire(&cwq->wq->lockdep_map, 0, 0, 0, 2, _THIS_IP_);
> +	lock_release(&cwq->wq->lockdep_map, 1, _THIS_IP_);
> +
>  	prev = NULL;
>  	spin_lock_irq(&cwq->lock);
>  	if (!list_empty(&work->entry)) {
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/