linux-kernel - Re: [PATCH] Make CONFIG_MIGRATION available for s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Jul 2008 13:32:56 -0500
From:	Christoph Lameter <cl@...ux-foundation.org>
To:	Gerald Schaefer <gerald.schaefer@...ibm.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Yasunori Goto <y-goto@...fujitsu.com>,
	Dave Hansen <haveblue@...ibm.com>,
	Andy Whitcroft <apw@...dowen.org>
Subject: Re: [PATCH] Make CONFIG_MIGRATION available for s390

Gerald Schaefer wrote:
> On Mon, 2008-07-07 at 12:38 -0500, Christoph Lameter wrote:
>> How does the compile break? It may be better to fix this where the function
>> is used.
> 
> Good point, I did not look into this deep enough and tried to fix the
> symptoms instead of the cause. There are two locations where the compile
> breaks:
> - mm/migrate.c: migrate_vmas() does not know vm_ops->migrate()

I think you just need to move the #endif from before migrate_vmas to the end (as you already suggested). Then migrate_vmas will no longer be compiled for the NUMA case. migrate_vmas() was added later and was not placed correctly it seems.

> - inlcude/linux/migrate.h: vma_migratable() does not know policy_zone

Again here you would have to add a new function.

vma_policy_migratable() should only be available for CONFIG_NUMA.

vma_migratable (without policy_zone check!) should be available if CONFIG_MIGRATION is on.
Not sure if we need such a test. If not then just make sure that vma_migratable() is
not included for the !NUMA case.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/