linux-kernel - Re: [PATCH 2/2] mmc: have mmc_align_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080708212234.62dc8c1b@mjolnir.drzeus.cx>
Date:	Tue, 8 Jul 2008 21:22:34 +0200
From:	Pierre Ossman <drzeus@...eus.cx>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	drzeus-sdhci@...eus.cx, sdhci-devel@...t.drzeus.cx,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mmc: have mmc_align_data_size use ALIGN() macro

On Mon, 7 Jul 2008 17:26:46 -0400
Andres Salomon <dilinger@...ued.net> wrote:

> 
> No sense manually doing the alignment dance, there's a macro for that.

There are so many macros in those headers, it's impossible to keep
track of them all. :/

> Once the optimal alignment stuff is added, this could
> probably turn into something like this (in core.h):
> 

I'm afraid you missed the main discussion, but the idea is to expand
that function and make it depend on the particular bugs of the
controller associated with the given card. I.e. it will not stay
suitable for inlining very long.

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)