linux-kernel - Re: [RFC 06/11] remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080708195736.GE11954@cs181140183.pp.htv.fi>
Date:	Tue, 8 Jul 2008 22:57:36 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [RFC 06/11] remove CONFIG_KMOD from fs

On Tue, Jul 08, 2008 at 07:00:21PM +0200, Johannes Berg wrote:
>...
> --- everything.orig/fs/nls/nls_base.c	2008-07-08 18:32:40.000000000 +0200
> +++ everything/fs/nls/nls_base.c	2008-07-08 18:34:44.000000000 +0200
>...
> @@ -216,15 +214,13 @@ static struct nls_table *find_nls(char *
>  struct nls_table *load_nls(char *charset)
>  {
>  	struct nls_table *nls;
> -#ifdef CONFIG_KMOD
>  	int ret;
> -#endif

That gives an "unused variable" gcc warning with CONFIG_MODULES=n.

>  	nls = find_nls(charset);
>  	if (nls)
>  		return nls;
>  
> -#ifdef CONFIG_KMOD
> +#ifdef CONFIG_MODULES
>  	ret = request_module("nls_%s", charset);
>  	if (ret != 0) {
>  		printk("Unable to load NLS charset %s\n", charset);
> 

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/