linux-kernel - Re: [PATCH] padlock: don't whinge when loaded on a non-VIA cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080708180833.61d24b60@bree.surriel.com>
Date:	Tue, 8 Jul 2008 18:08:33 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Kyle McMartin <kyle@...artin.ca>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, kyle@...artin.ca,
	kmcmartin@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] padlock: don't whinge when loaded on a non-VIA cpu

On Tue, 8 Jul 2008 15:37:41 -0400
Kyle McMartin <kyle@...artin.ca> wrote:

> +	if (!((boot_cpu_data.x86_vendor == X86_VENDOR_CENTAUR) &&
> +	     (boot_cpu_data.x86 >= 6)))	/* only on VIA C3 and above */
> +		return -ENODEV;

Why add this?

>  	if (!cpu_has_xcrypt) {
>  		printk(KERN_ERR PFX "VIA PadLock not detected.\n");
>  		return -ENODEV;

When you could simply delete the printk lines?

-- 
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/