linux-kernel - Re: [PATCH 19/58] microblaze_v5: early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d3f23370807081647y446534dp6db16f560e4e0a2d@mail.gmail.com>
Date:	Wed, 9 Jul 2008 09:47:29 +1000
From:	"John Williams" <john.williams@...alogix.com>
To:	monstr@...str.eu
Cc:	linux-kernel@...r.kernel.org, monstr@...nam.cz, arnd@...db.de,
	linux-arch@...r.kernel.org, stephen.neuendorffer@...inx.com,
	John.Linn@...inx.com, matthew@....cx, will.newton@...il.com,
	drepper@...hat.com, microblaze-uclinux@...e.uq.edu.au,
	grant.likely@...retlab.ca, vapier.adi@...il.com,
	alan@...rguk.ukuu.org.uk, hpa@...or.com, lethal@...ux-sh.org,
	florian@...nwrt.org
Subject: Re: [PATCH 19/58] microblaze_v5: early_printk support

> +++ b/arch/microblaze/kernel/early_printk.c
> @@ -0,0 +1,130 @@

> +#ifdef CONFIG_EARLY_PRINTK
> +#define BASE_ADDR ((unsigned char *)CONFIG_EARLY_PRINTK_UARTLITE_ADDRESS)

This is a problem - default value of EARLY_PRINTK_UARTLITE_ADDRESS is
0x0, so by default the kernel will try to access a uartlite at 0x0
which is the reset vector!  I know there is the test in the actual
output routine but it's not good to rely on that in the default case.

Can we either

#if CONFIG_EARLY_PRINTK_UARTLITE_ADDRESS==0
#warning EARLY_PRINTK address not set, disabling
...
#else
..
#endif

or query the OF subsystem (is it up yet?), and default to using the
first uartlite in the system for early printk?

John
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/