linux-kernel - Re: [PATCH] bnx2 - use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080708073922.6c2470c1@the-village.bc.nu>
Date:	Tue, 8 Jul 2008 07:39:22 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	mchan@...adcom.com, dwmw2@...radead.org, bastian@...di.eu.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bnx2 - use request_firmware()

> The firmware needs to be reloaded every time the chip resets.
> You're not saving anything/

> See above, you aren't saving anything.  The firmware needs to stay
> around so it can be reloaded into the card during exceptions.
> 
> That is, unless you want a more failure prone system.

Ok so if tg3 always needs the same firmware and always needs it in memory
then maybe it isn't a significant candidate for request_firmware beyond
the neatness of distribution. I note the firmware hasn't changed in years
so it can easily be shipped separately and the one package would have
done for all this time.

> > Driver authors aren't God.
> 
> They (actually, more specifically the maintainers) to a certain extent
> are, because they are the ones who eat doo-doo when something explodes.

So do the distributions and the users.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/