linux-kernel - Re: [PATCH] bnx2 - use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080708074947.2734d71f@the-village.bc.nu>
Date:	Tue, 8 Jul 2008 07:49:47 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	david@...g.hm
Cc:	David Miller <davem@...emloft.net>, mchan@...adcom.com,
	dwmw2@...radead.org, bastian@...di.eu.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bnx2 - use request_firmware()

> so make the firmware part of the module if the driver is compiled as a 
> module. this way if the driver (and firmware) end up not being used they 
> don't take up any space. this seems a lot simpler (as well as more 
> reliable) then adding a mandatory dependancy on a different userspace 
> tool.

For the majority of drivers that would be a serious regression as they
load the firmware when needed, which is not when loaded. In some cases
there are many sets of firmware and only one is needed according to the
device, and only needed once per device detect.

It might well make sense for tg3 although even there it seems most tg3
work fine without loading new firmware, and examples like aic7xxx where
the firmware and code must match.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/