linux-kernel - Re: [PATCH] crypto/tcrypt.c fix resource leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080708082248.GA25297@gondor.apana.org.au>
Date:	Tue, 8 Jul 2008 16:22:49 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	"Darren Jenkins\"" <darrenrjenkins@...il.com>
Cc:	kernel Janitors <kernel-janitors@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, davem@...emloft.net,
	linux-crypto@...r.kernel.org, jmorris@...ercode.com.au,
	jef@...uxbe.org
Subject: Re: [PATCH] crypto/tcrypt.c fix resource leak

On Tue, Jul 08, 2008 at 05:24:14AM +1000, Darren Jenkins" wrote:
> G'day people,
> 
> Coverity CID: 2306 & 2307 RESOURCE_LEAK
> 
> In the second for loop in test_cipher(), data is allocated space with
> kzalloc() and is only ever freed in an error case.
> Looking at this loop, data is written to this memory but nothing seems
> to read from it. 
> So here is a patch removing the allocation, I think this is the right
> fix.
> 
> Only compile tested.
> 
> Signed-off-by: Darren Jenkins <darrenrjenkins@...ilcom>

Patch applied.  Thanks!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/