linux-kernel - Re: [Patch 06/10] mfd: PCAP driver for the Motorola EZX GSM mobile phones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <487423B3.3010604@gmail.com>
Date:	Wed, 09 Jul 2008 10:34:27 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Stefan Schmidt <stefan@...enfreihafen.org>
CC:	Daniel Ribeiro <drwyrm@...il.com>,
	pHilipp Zabel <philipp.zabel@...il.com>,
	linux-arm-kernel@...ts.arm.linux.org.uk, sameo@...nedhand.com,
	linux-kernel@...r.kernel.org
Subject: Re: [Patch 06/10] mfd: PCAP driver for the Motorola EZX GSM mobile
 phones


> o Eric, what do you like the PCAP_REDIRECT_IRQ flag to do?
> 

I'm seeing the following the block of code in the original patch:
 
+/* PCAP */
+static int ezx_pcap_init(void)
+{

...

+	/* redirect all interrupts to AP */
+	if (!(machine_is_ezx_a780() || machine_is_ezx_e680()))
+		ezx_pcap_write(PCAP_REG_INT_SEL, 0);
+
+	return 0;
+}

that prevent this driver from being generic, a flag of PCAP_REDIRECT_IRQ
might be used to decide the writing to PCAP_REG_INT_SEL is necessary.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/