linux-kernel - Re: [PATCH] Mark i2o config broken on 64-bit platforms.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080709044743.0dd15a3f.akpm@linux-foundation.org>
Date:	Wed, 9 Jul 2008 04:47:43 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
Cc:	alan@...hat.com, Markus.Lidel@...dowconnect.com, vvs@...ru,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] Mark i2o config broken on 64-bit platforms.

On Wed, 09 Jul 2008 12:35:47 +0100 David Howells <dhowells@...hat.com> wrote:

> Mark i2o config broken on 64-bit platforms as it generates these:
> 
> In file included from drivers/message/i2o/config-osm.c:39:
> drivers/message/i2o/i2o_config.c: In function 'i2o_cfg_passthru':
> drivers/message/i2o/i2o_config.c:889: warning: cast to pointer from integer of different size
> drivers/message/i2o/i2o_config.c:945: warning: cast to pointer from integer of different size
> 
> which are apparently non-trivial to fix (eg: inserting a cast through unsigned
> long is not correct according to Linus).  This would be due to struct
> sg_simple_element only having a 32-bit addr_bus value.
> 
> There are also a number of "TODO 64bit fix" comments.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>
> ---
> 
>  drivers/message/i2o/Kconfig |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/drivers/message/i2o/Kconfig b/drivers/message/i2o/Kconfig
> index 5afa0e3..c102225 100644
> --- a/drivers/message/i2o/Kconfig
> +++ b/drivers/message/i2o/Kconfig
> @@ -54,7 +54,7 @@ config I2O_EXT_ADAPTEC_DMA64
>  
>  config I2O_CONFIG
>  	tristate "I2O Configuration support"
> -	depends on VIRT_TO_BUS
> +	depends on VIRT_TO_BUS && (BROKEN || !64BIT)
>  	---help---
>  	  Say Y for support of the configuration interface for the I2O adapters.
>  	  If you have a RAID controller from Adaptec and you want to use the
> @@ -66,6 +66,8 @@ config I2O_CONFIG
>  	  Note: If you want to use the new API you have to download the
>  	  i2o_config patch from http://i2o.shadowconnect.com/
>  
> +	  Note: This is broken on 64-bit architectures.
> +
>  config I2O_CONFIG_OLD_IOCTL
>  	bool "Enable ioctls (OBSOLETE)"
>  	depends on I2O_CONFIG

Sigh.  I've been staring at that warning for so long.

Is it actually known to be broken on 64-bit, or does it happen to work?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/