linux-kernel - Re: [PATCH] ext4: handle deleting corrupted indirect blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080709025304.GG9957@mit.edu>
Date:	Tue, 8 Jul 2008 22:53:04 -0400
From:	Theodore Tso <tytso@....edu>
To:	Duane Griffin <duaneg@...da.com>
Cc:	akpm@...ux-foundation.org, sct@...hat.com, adilger@...sterfs.com,
	Mingming <cmm@...ibm.com>, Sami Liedes <sliedes@...hut.fi>,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: handle deleting corrupted indirect blocks

On Tue, Jul 08, 2008 at 03:42:00PM +0100, Duane Griffin wrote:
> +		if (bh2jh(this_bh))
> +			ext4_journal_dirty_metadata(handle, this_bh);
> +		else
> +			ext4_error(inode->i_sb, __func__,
> +				   "circular indirect block detected, "
> +				   "inode=%lu, block=%lu",
> +				   inode->i_ino, this_bh->b_blocknr);

this_bh->b_blocknr is a sector_t, which could be 64-bits.  So this
should be:

			ext4_error(inode->i_sb, __func__,
				   "circular indirect block detected, "
				   "inode=%lu, block=%llu",
				   inode->i_ino,
				   (unsigned long long) this_bh->b_blocknr);

I think.

With this change, I've included your three patches into the ext4 patch
queue.

						- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/