linux-kernel - Re: [PATCH 2/3] stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807091218.57205.rusty@rustcorp.com.au>
Date:	Wed, 9 Jul 2008 12:18:56 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	"Akinobu Mita" <akinobu.mita@...il.com>
Cc:	linux-kernel@...r.kernel.org, "Jason Baron" <jbaron@...hat.com>,
	"Mathieu Desnoyers" <mathieu.desnoyers@...ymtl.ca>,
	"Max Krasnyansky" <maxk@...lcomm.com>,
	"Hidetoshi Seto" <seto.hidetoshi@...fujitsu.com>
Subject: Re: [PATCH 2/3] stop_machine: simplify

On Wednesday 09 July 2008 01:02:02 Akinobu Mita wrote:
> 2008/7/8 Rusty Russell <rusty@...tcorp.com.au>:
> > On Tuesday 08 July 2008 21:44:40 Akinobu Mita wrote:
> >> I found a small possible cleanup in this patch.
> >
> > Well spotted!  I think this cleanup is actually orthogonal to my patch,
> > so best served as a separate patch, how's this?
>
> Actually the cpu_online() check was necessary before appling this
> stop_machine: simplify patch.
>
> With old __stop_machine_run(), __stop_machine_run() could succeed
> (return !IS_ERR(p) value) even if take_cpu_down() returned non-zero value.
> The return value of take_cpu_down() was obtained through kthread_stop().

Ah, thanks for the analysis!

It's a little non-obvious, so I've left it as a separate patch (it doesn't 
hurt to have the check there), but included your excellent explanation within 
it.

Thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/