linux-kernel - Re: [patch] power, xen64: fix PM_SLEEP build dependencies (was: Re: [PATCH 00 of 55] xen64: implement 64-bit Xen support)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807092159.35288.rjw@sisk.pl>
Date:	Wed, 9 Jul 2008 21:59:34 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
	Stephen Tweedie <sct@...hat.com>,
	Eduardo Habkost <ehabkost@...hat.com>,
	Mark McLoughlin <markmc@...hat.com>
Subject: Re: [patch] power, xen64: fix PM_SLEEP build dependencies (was: Re: [PATCH 00 of 55] xen64: implement 64-bit Xen support)

On Wednesday, 9 of July 2008, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@...e.hu> wrote:
> 
> > -tip testing found another PM/PM_SLEEP victim:
> > 
> >  arch/x86/kernel/built-in.o: In function `suspend':
> >  apm_32.c:(.text+0xedb5): undefined reference to `save_processor_state'
> >  apm_32.c:(.text+0xedd0): undefined reference to `restore_processor_state'
> 
> ah, found it - the arch-level power/ directory had a CONFIG_PM-only 
> build dependency as well. Fixed via the commit below.
> 
> 	Ingo
> 
> ------------->
> commit 6666fa5ebb7c78afcab540bf183c7f070c890930
> Author: Ingo Molnar <mingo@...e.hu>
> Date:   Wed Jul 9 21:45:54 2008 +0200
> 
>     power, xen64: fix PM_SLEEP build dependencies, #2
>     
>     -tip testing found another PM/PM_SLEEP victim:
>     
>      arch/x86/kernel/built-in.o: In function `suspend':
>      apm_32.c:(.text+0xedb5): undefined reference to `save_processor_state'
>      apm_32.c:(.text+0xedd0): undefined reference to `restore_processor_state'
>     
>     with this config:
>     
>      http://redhat.com/~mingo/misc/config-Wed_Jul__9_18_53_45_CEST_2008.bad
>     
>     the core scenario is this combination (and only this combination) of
>     config values:
>     
>       # CONFIG_PM is not set
>       CONFIG_PM_SLEEP=y
>       CONFIG_APM=y
>       CONFIG_PARAVIRT=y
>       CONFIG_XEN=y

This combination actually doesn't make sense whatsoever.

PM_SLEEP depends (indirectly) on PM and the fact that it's possible to use
a .config violating this dependency is a build system problem, really.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/