lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Jul 2008 22:17:52 +0200 From: "Rafael J. Wysocki" <rjw@...k.pl> To: Ingo Molnar <mingo@...e.hu> Cc: Jeremy Fitzhardinge <jeremy@...p.org>, LKML <linux-kernel@...r.kernel.org>, x86@...nel.org, Stephen Tweedie <sct@...hat.com>, Eduardo Habkost <ehabkost@...hat.com>, Mark McLoughlin <markmc@...hat.com> Subject: Re: [patch] power, xen64: fix PM_SLEEP build dependencies (was: Re: [PATCH 00 of 55] xen64: implement 64-bit Xen support) On Wednesday, 9 of July 2008, Ingo Molnar wrote: > > * Rafael J. Wysocki <rjw@...k.pl> wrote: > > > > This combination actually doesn't make sense whatsoever. > > > > > > PM_SLEEP depends (indirectly) on PM and the fact that it's possible > > > to use a .config violating this dependency is a build system > > > problem, really. > > > > Your patch is correct, though. :-) > > yes, that combination doesnt make sense in -git, but tip/xen64 tries the > !PM && PM_SLEEP combination - see the patch below. It shouldn't. There are many things compiled if PM is set that PM_SLEEP depends on, most importantly ->suspend() and ->resume() callbacks of almost all drivers. Ignoring this dependency is asking for trouble. > What do you think about that patch? > > I think Jeremy's patch makes sense, but no strong feelings. We can > certainly map out these side-effects. (the fixes you've been Cc:-ed to > should be roughly all that can happen i think.) > -------------------> > commit 6fbbec428c8e7bb617da2e8a589af2e97bcf3bc4 > Author: Jeremy Fitzhardinge <jeremy@...p.org> > Date: Tue Jul 8 15:07:08 2008 -0700 > > suspend, xen: enable PM_SLEEP for CONFIG_XEN > > Xen save/restore requires PM_SLEEP to be set without requiring > SUSPEND or HIBERNATION. > > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com> > Cc: Stephen Tweedie <sct@...hat.com> > Cc: Eduardo Habkost <ehabkost@...hat.com> > Cc: Mark McLoughlin <markmc@...hat.com> > Signed-off-by: Ingo Molnar <mingo@...e.hu> > > diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig > index b45da40..1436c47 100644 > --- a/kernel/power/Kconfig > +++ b/kernel/power/Kconfig > @@ -82,7 +82,7 @@ config PM_SLEEP_SMP > > config PM_SLEEP > bool > - depends on SUSPEND || HIBERNATION > + depends on SUSPEND || HIBERNATION || XEN > default y > > config SUSPEND I don't like this. I'll have a look at the remaining related patches and see what can be done. Jeremy, what exactly do you need the !PM && PM_SLEEP combination for, BTW? Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists