linux-kernel - Re: [BUG] CFS vs cpu hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080710073938.GB21543@elte.hu>
Date:	Thu, 10 Jul 2008 09:39:38 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Dmitry Adamushko <dmitry.adamushko@...il.com>,
	miaox@...fujitsu.com, Lai Jiangshan <laijs@...fujitsu.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Avi Kivity <avi@...ranet.com>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [BUG] CFS vs cpu hotplug


* Heiko Carstens <heiko.carstens@...ibm.com> wrote:

> > Subject: sched: prevent a potentially endless loop in 
> > move_task_off_dead_cpu()
> > 
> > Interrupts are enabled on other CPUs when migration_call(CPU_DEAD, 
> > ...) is called so we may get a race between try_to_wake_up() and 
> > migrate_live_tasks() -> move_task_off_dead_cpu(). The former one may 
> > push a task out of a dead CPU causing the later one to loop 
> > endlessly.
> 
> That's exactly what explains a dump I got yesterday. Thanks for 
> fixing! :)

applied to tip/sched/urgent via the commit below - lets see whether we 
can still get it into v2.6.26.

	Ingo

---------------->
commit dc7fab8b3bb388c57c6c4a43ba68c8a32ca25204
Author: Dmitry Adamushko <dmitry.adamushko@...il.com>
Date:   Thu Jul 10 00:32:40 2008 +0200

    sched: fix cpu hotplug
    
    I think we may have a race between try_to_wake_up() and
    migrate_live_tasks() -> move_task_off_dead_cpu() when the later one
    may end up looping endlessly.
    
    Interrupts are enabled on other CPUs when migration_call(CPU_DEAD, ...) is
    called so we may get a race between try_to_wake_up() and
    migrate_live_tasks() -> move_task_off_dead_cpu(). The former one may push
    a task out of a dead CPU causing the later one to loop endlessly.
    
    Heiko Carstens observed:
    
    | That's exactly what explains a dump I got yesterday. Thanks for fixing! :)
    
    Signed-off-by: Dmitry Adamushko <dmitry.adamushko@...il.com>
    Cc: miaox@...fujitsu.com
    Cc: Lai Jiangshan <laijs@...fujitsu.com>
    Cc: Heiko Carstens <heiko.carstens@...ibm.com>
    Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
    Cc: Avi Kivity <avi@...ranet.com>
    Cc: Andrew Morton <akpm@...ux-foundation.org>
    Signed-off-by: Ingo Molnar <mingo@...e.hu>

diff --git a/kernel/sched.c b/kernel/sched.c
index 94ead43..9397b87 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -5621,8 +5621,10 @@ static int __migrate_task(struct task_struct *p, int src_cpu, int dest_cpu)
 
 	double_rq_lock(rq_src, rq_dest);
 	/* Already moved. */
-	if (task_cpu(p) != src_cpu)
+	if (task_cpu(p) != src_cpu) {
+		ret = 1;
 		goto out;
+	}
 	/* Affinity changed (again). */
 	if (!cpu_isset(dest_cpu, p->cpus_allowed))
 		goto out;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/