linux-kernel - Re: [PATCH] uio: uio_pdrv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080710134946.GC3202@local>
Date:	Thu, 10 Jul 2008 15:49:46 +0200
From:	"Hans J. Koch" <hjk@...utronix.de>
To:	Uwe Kleine-König <Uwe.Kleine-Koenig@...i.com>
Cc:	"Hans J. Koch" <hjk@...utronix.de>,
	Magnus Damm <magnus.damm@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"gregkh@...e.de" <gregkh@...e.de>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"lethal@...ux-sh.org" <lethal@...ux-sh.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"alan@...rguk.ukuu.org.uk" <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] uio: uio_pdrv_genirq V2

On Thu, Jul 10, 2008 at 01:06:31PM +0200, Uwe Kleine-König wrote:
> Hi,
> 
> Hans J. Koch wrote:
> > > > +       ret = uio_register_device(&pdev->dev, priv->uioinfo);
> > > > +       if (ret) {
> > > > +               dev_err(&pdev->dev, "unable to register uio device\n");
> > > > +               goto bad1;
> > > > +       }
> > > > +
> > > > +       platform_set_drvdata(pdev, priv);
> > > This should probably go before uio_register_device.  (Uups, this is an
> > > issue for uio_pdrv, too.)
> > 
> > Yes, because uio_register_device will enable the irq, and you might
> > arrive in the handler without having your platform data in place.
> How do we want to fix that?  Should I sent a new version that also
> includes the memory-leak fix and copyright specification?  Or another
> incremental patch?

Send another incremental patch for uio_pdrv, just for the records.
I'll sort it out with Greg later, if he finds many small patches
annoying, I can easily combine them.

Thanks,
Hans

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/