linux-kernel - Re: [PATCH] x86_64: reserve crashkernel bootmem before reserve dma32 bootmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440807101032h6fc6cf16l829e4932477f43b3@mail.gmail.com>
Date:	Thu, 10 Jul 2008 10:32:35 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Joe Jin" <joe.jin@...cle.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Andi Kleen" <andi@...stfloor.org>, greg.marsden@...cle.com,
	tao.ma@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86_64: reserve crashkernel bootmem before reserve dma32 bootmem

On Thu, Jul 10, 2008 at 5:34 AM, Joe Jin <joe.jin@...cle.com> wrote:
> Before reserve_crashkernel, dma32_reserve_bootmem would reserve 128M memory.
> this cuased crashkernel end address must less than 64M or start address must
> more than 192M except crashkernel memory reserved before dma32 memory reserved.
>
> This patch against 2.6.26-rc9
>
> Signed-off-by: Joe Jin <joe.jin@...cle.com>
> ---
>  setup_64.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.26-rc9/arch/x86/kernel/setup_64.c.orig    2008-07-10 16:34:12.000000000 +0800
> +++ linux-2.6.26-rc9/arch/x86/kernel/setup_64.c 2008-07-10 16:35:00.000000000 +0800
> @@ -444,8 +444,6 @@ void __init setup_arch(char **cmdline_p)
>        contig_initmem_init(0, end_pfn);
>  #endif
>
> -       dma32_reserve_bootmem();
> -
>  #ifdef CONFIG_ACPI_SLEEP
>        /*
>         * Reserve low memory region for sleep support.
> @@ -486,6 +484,8 @@ void __init setup_arch(char **cmdline_p)
>  #endif
>        reserve_crashkernel();
>
> +       dma32_reserve_bootmem();
> +
>        reserve_ibft_region();
>
>        paging_init();

Acked-by: Yinghai Lu <yhlu.kernel@...il.com>

BTW: current tip/master already make dma32_reserve_bootmem start from 512M
http://people.redhat.com/mingo/tip.git/readme.txt

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/