| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <487651CA.6030405@gmail.com>
Date: Thu, 10 Jul 2008 20:15:38 +0200
From: Jiri Slaby <jirislaby@...il.com>
To: Michael Buesch <mb@...sch.de>
CC: Andrew Morton <akpm@...ux-foundation.org>,
Stephen Rothwell <sfr@...b.auug.org.au>, mchehab@...radead.org,
linux-kernel <linux-kernel@...r.kernel.org>,
Marcel Holtmann <marcel@...tmann.org>,
David Brownell <david-b@...bell.net>
Subject: Re: [PATCH v3] Add bt8xxgpio driver
<Moved from the bottom>
+A·generic·digital·24-port·PCI·GPIO·card·can·be·built·out·of·an·ordinary
+Brooktree·bt848,·bt849,·bt878·or·bt879·based·analog·TV·tuner·card.·The
+Brooktree·chip·is·used·in·old·analog·Hauppauge·WinTV·PCI·cards.·You·can·easily
+find·them·used·for·low·prices·on·the·net.
Thanks for that!
On 07/10/2008 07:14 PM, Michael Buesch wrote:
> Index: linux-next/drivers/gpio/bt8xxgpio.c
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-next/drivers/gpio/bt8xxgpio.c 2008-07-10 19:05:56.000000000 +0200
> @@ -0,0 +1,348 @@
[...]
> +static int bt8xxgpio_gpio_direction_input(struct gpio_chip *gpio, unsigned nr)
> +{
> + struct bt8xxgpio *bg = container_of(gpio, struct bt8xxgpio, gpio);
> + unsigned long flags;
> + u32 outen, data;
> +
> + spin_lock_irqsave(&bg->lock, flags);
Why all those irq variants? I can't see interrupts anywhere. May gpio call this
from irq?
> +
> + data = bgread(BT848_GPIO_DATA);
> + data &= ~(1 << nr);
> + bgwrite(data, BT848_GPIO_DATA);
> +
> + outen = bgread(BT848_GPIO_OUT_EN);
> + outen &= ~(1 << nr);
> + bgwrite(outen, BT848_GPIO_OUT_EN);
some flushing of posted values here?
> + spin_unlock_irqrestore(&bg->lock, flags);
> +
> + return 0;
> +}
[...]
> +static int bt8xxgpio_gpio_direction_output(struct gpio_chip *gpio,
> + unsigned nr, int val)
> +{
> + struct bt8xxgpio *bg = container_of(gpio, struct bt8xxgpio, gpio);
> + unsigned long flags;
> + u32 outen, data;
> +
> + spin_lock_irqsave(&bg->lock, flags);
> +
> + outen = bgread(BT848_GPIO_OUT_EN);
> + outen |= (1 << nr);
> + bgwrite(outen, BT848_GPIO_OUT_EN);
> +
> + data = bgread(BT848_GPIO_DATA);
> + if (val)
> + data |= (1 << nr);
> + else
> + data &= ~(1 << nr);
> + bgwrite(data, BT848_GPIO_DATA);
and here
> +
> + spin_unlock_irqrestore(&bg->lock, flags);
> +
> + return 0;
> +}
> +
> +static void bt8xxgpio_gpio_set(struct gpio_chip *gpio,
> + unsigned nr, int val)
> +{
> + struct bt8xxgpio *bg = container_of(gpio, struct bt8xxgpio, gpio);
> + unsigned long flags;
> + u32 data;
> +
> + spin_lock_irqsave(&bg->lock, flags);
> +
> + data = bgread(BT848_GPIO_DATA);
> + if (val)
> + data |= (1 << nr);
> + else
> + data &= ~(1 << nr);
> + bgwrite(data, BT848_GPIO_DATA);
and here and further in the code
> + spin_unlock_irqrestore(&bg->lock, flags);
> +}
[...]
> +static int bt8xxgpio_probe(struct pci_dev *dev,
> + const struct pci_device_id *pci_id)
> +{
> + struct bt8xxgpio *bg;
> + int err;
> +
> + bg = kzalloc(sizeof(*bg), GFP_KERNEL);
> + if (!bg)
> + return -ENOMEM;
> +
> + bg->pdev = dev;
> + spin_lock_init(&bg->lock);
> +
> + err = pci_enable_device(dev);
> + if (err) {
> + printk(KERN_ERR "bt8xxgpio: Can't enable device.\n");
dev_err() et al. all over here.
> + goto err_freebg;
> + }
> + if (!request_mem_region(pci_resource_start(dev, 0),
> + pci_resource_len(dev, 0),
> + "bt8xxgpio")) {
pci_request_region();?
> + printk(KERN_WARNING
> + "bt8xxgpio: Can't request iomem (0x%llx).\n",
> + (unsigned long long)pci_resource_start(dev, 0));
You don't need to print the value out, we can see it in lspci.
> + err = -EBUSY;
> + goto err_disable;
> + }
> + pci_set_master(dev);
> + pci_set_drvdata(dev, bg);
> +
> + bg->mmio = ioremap(pci_resource_start(dev, 0), 0x1000);
> + if (!bg->mmio) {
> + printk(KERN_ERR "bt8xxgpio: ioremap() failed\n");
> + err = -EIO;
> + goto err_release_mem;
> + }
[...]
> +static int bt8xxgpio_resume(struct pci_dev *pdev)
> +{
> + struct bt8xxgpio *bg = pci_get_drvdata(pdev);
> + unsigned long flags;
> + int err;
> +
> + pci_set_power_state(pdev, 0);
No need to set that state again (PCI layer cares).
> + err = pci_enable_device(pdev);
> + if (err)
> + return err;
> + pci_restore_state(pdev);
> +
> + spin_lock_irqsave(&bg->lock, flags);
[...]
> +static int bt8xxgpio_init(void)
__init
> +{
> + return pci_register_driver(&bt8xxgpio_pci_driver);
> +}
> +module_init(bt8xxgpio_init)
> +
> +static void bt8xxgpio_exit(void)
__exit
> +{
> + pci_unregister_driver(&bt8xxgpio_pci_driver);
> +}
> +module_exit(bt8xxgpio_exit)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists