linux-kernel - Re: [PATCH 02/34] AMD IOMMU: add header file for driver data structures and defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080709183823.52bbfd37.akpm@linux-foundation.org>
Date:	Wed, 9 Jul 2008 18:38:23 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	tglx@...utronix.de, mingo@...hat.com, linux-kernel@...r.kernel.org,
	iommu@...ts.linux-foundation.org, bhavna.sarathy@....com,
	Sebastian.Biemueller@....com, robert.richter@....com,
	joro@...tes.org
Subject: Re: [PATCH 02/34] AMD IOMMU: add header file for driver data
 structures and defines

On Thu, 26 Jun 2008 21:27:38 +0200 Joerg Roedel <joerg.roedel@....com> wrote:

> +/* helper macros */
> +#define LOW_U32(x) ((x) & ((1ULL << 32)-1))
> +#define HIGH_U32(x) (LOW_U32((x) >> 32))

Please avoid putting general-purpose helpers into private header files.

If we already have helper functions for this then use them.

If we don't have such helpers, let's write them, get them reviewed and put
them into kernel.h.

If we don't want these helpers in kernel.h then we don't want them in the
iommu driver either.

This cleanup work can be done separately from reviewing, testing amd
merging the IOMMU driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/