linux-kernel - Re: [PATCH 16/34] AMD IOMMU: add kernel command line parameters for AMD IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080709185634.08c60937.akpm@linux-foundation.org>
Date:	Wed, 9 Jul 2008 18:56:34 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	tglx@...utronix.de, mingo@...hat.com, linux-kernel@...r.kernel.org,
	iommu@...ts.linux-foundation.org, bhavna.sarathy@....com,
	Sebastian.Biemueller@....com, robert.richter@....com,
	joro@...tes.org
Subject: Re: [PATCH 16/34] AMD IOMMU: add kernel command line parameters for
 AMD IOMMU

On Thu, 26 Jun 2008 21:27:52 +0200 Joerg Roedel <joerg.roedel@....com> wrote:

> This patch adds two parameters to the kernel command line to control behavior
> of the AMD IOMMU.
> 
> Signed-off-by: Joerg Roedel <joerg.roedel@....com>
> ---
>  arch/x86/kernel/amd_iommu_init.c |   34 ++++++++++++++++++++++++++++++++++
>  1 files changed, 34 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
> index d7a75bf..ec6f13b 100644
> --- a/arch/x86/kernel/amd_iommu_init.c
> +++ b/arch/x86/kernel/amd_iommu_init.c
> @@ -789,3 +789,37 @@ void __init amd_iommu_detect(void)
>  	}
>  }
>  
> +static int __init parse_amd_iommu_options(char *str)
> +{
> +	for (; *str; ++str) {
> +		if (strcmp(str, "off") == 0)
> +			amd_iommu_disable = 1;
> +		if (strcmp(str, "isolate") == 0)
> +			amd_iommu_isolate = 1;
> +	}
> +
> +	return 1;
> +}
> +
> +static int __init parse_amd_iommu_size_options(char *str)
> +{
> +	for (; *str; ++str) {
> +		if (strcmp(str, "32M") == 0)
> +			amd_iommu_aperture_order = 25;
> +		if (strcmp(str, "64M") == 0)
> +			amd_iommu_aperture_order = 26;
> +		if (strcmp(str, "128M") == 0)
> +			amd_iommu_aperture_order = 27;
> +		if (strcmp(str, "256M") == 0)
> +			amd_iommu_aperture_order = 28;
> +		if (strcmp(str, "512M") == 0)
> +			amd_iommu_aperture_order = 29;
> +		if (strcmp(str, "1G") == 0)
> +			amd_iommu_aperture_order = 30;
> +	}
> +
> +	return 1;
> +}
> +
> +__setup("amd_iommu=", parse_amd_iommu_options);
> +__setup("amd_iommu_size=", parse_amd_iommu_size_options);

Please document kernel boot parameters in Documentation/kernel-parameters.txt.

I think you just reimplemented memparse().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/