linux-kernel - RE: [PATCH] ftrace port to tracepoints (linux-next)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <010401c8e23b$020b6c30$06224490$@css.fujitsu.com>
Date:	Thu, 10 Jul 2008 12:14:01 +0900
From:	"Takashi Nishiie" <t-nishiie@...css.fujitsu.com>
To:	"'Mathieu Desnoyers'" <mathieu.desnoyers@...ymtl.ca>,
	<akpm@...ux-foundation.org>, "'Ingo Molnar'" <mingo@...e.hu>,
	<linux-kernel@...r.kernel.org>,
	"'Peter Zijlstra'" <peterz@...radead.org>
Cc:	"'Steven Rostedt'" <rostedt@...dmis.org>,
	"'Thomas Gleixner'" <tglx@...utronix.de>,
	"'Masami Hiramatsu'" <mhiramat@...hat.com>,
	"'Frank Ch. Eigler'" <fche@...hat.com>,
	"'Hideo AOKI'" <haoki@...hat.com>,
	"'Eduard - Gabriel Munteanu'" <eduard.munteanu@...ux360.ro>
Subject: RE: [PATCH] ftrace port to tracepoints (linux-next)

Hi,Mathieu

I think that it is wonderful that the source code becomes simple by 
changing kernel markers to tracepoints. 

However, it seems to forget to correct the error message.

For example.
Mathieu Wrote:
>-	ret = marker_probe_register("kernel_sched_wakeup",
>-			"pid %d state %ld ## rq %p task %p rq->curr %p",
>-			wake_up_callback,
>-			&ctx_trace);
>+	ret = register_trace_sched_wakeup(probe_sched_wakeup);
> 	if (ret) {
> 		pr_info("wakeup trace: Couldn't add marker"
> 			" probe to kernel_sched_wakeup\n");
> 		return ret;
> 	}

 	if (ret) {
- 		pr_info("wakeup trace: Couldn't add marker"
+		pr_info("wakeup trace: Couldn't activate tracepoint"
 			" probe to kernel_sched_wakeup\n");
 		return ret;
 	}

Thank you,
--
Takashi Nishiie



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/