linux-kernel - Re: [x86, patch] turn x86 VISWS into a generic architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080711091041.GA30198@elte.hu>
Date:	Fri, 11 Jul 2008 11:10:41 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Robert Richter <robert.richter@....com>,
	linux-kernel@...r.kernel.org,
	the arch/x86 maintainers <x86@...nel.org>,
	James Bottomley <James.Bottomley@...senpartnership.com>
Subject: Re: [x86, patch] turn x86 VISWS into a generic architecture

* Yinghai Lu <yhlu.kernel@...il.com> wrote:

> > Ok. Mind sending a patch for this against tip/master? Both your 
> > changes and the visws cleanups are all in there and are tested 
> > through on typical hardware.
> >
> > (Also, there's the suggestion from Yinghai to first do the numa 
> > init.)
> 
> could change the numa.c to numaq.c too. that name is confusing..

agreed. Maybe rename it to numaq_32.c as well.

Then we could potentially eliminate the NUMAQ subarch altogether as well 
and merge all it into arch/x86/kernel/numaq_quirks.c, just like we did 
it for arch/x86/kernel/visws_quirks.c?

That reminds me, wouldnt it all be better in a single place, i.e. move 
arch/x86/pci/visws.c into arch/x86/kernel/visws_quirks.c as well? Such 
quirks are better viewed in their entirety in a single file, i'm not 
sure it makes sense to spread them out.

This way, instead of having this mess of entire subarches, we'd have a 
single, clean "quirks driver" file, conditionally buildable into the 
generic PC code, that would register itself with all the generic quirk 
hooks that are needed for a given weird box.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/