linux-kernel - Re: [PATCH 1/2] regulator: TI bq24022 Li-Ion Charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1215772087.6634.7.camel@odin>
Date:	Fri, 11 Jul 2008 11:28:07 +0100
From:	Liam Girdwood <lg@...nsource.wolfsonmicro.com>
To:	Philipp Zabel <philipp.zabel@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH 1/2] regulator: TI bq24022 Li-Ion Charger driver

On Thu, 2008-07-10 at 21:04 +0200, Philipp Zabel wrote:
> This adds a regulator driver for the TI bq24022 Single-Chip
> Li-Ion Charger with its nCE and ISET2 pins connected to GPIOs.

snip

> +static struct platform_driver bq24022_driver = {
> +	.driver = {
> +		.name = "bq24022",
> +	},
> +	.remove = __devexit_p(bq24022_remove),
> +};
> +
> +static int __init bq24022_init()

missing void

> +{
> +	platform_driver_probe(&bq24022_driver, bq24022_probe);
> +}
> +

missing return value.

> +static void __exit bq24022_exit()

missing void

> +{
> +	platform_driver_unregister(&bq24022_driver);
> +}

Could you fix these and resubmit.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/