linux-kernel - Re: [PATCH] Fix ia64 simserial.c for Ldisc revamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080711135031.GB23319@devserv.devel.redhat.com>
Date:	Fri, 11 Jul 2008 09:50:31 -0400
From:	Alan Cox <alan@...hat.com>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	"alan@...hat.com" <alan@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix ia64 simserial.c for Ldisc revamp

On Thu, Jul 10, 2008 at 01:46:49PM -0700, Luck, Tony wrote:
> This driver is "hidden" in arch/ia64 ... so it didn't get updated
> by the Ldisc revamp.
> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> 
> 
> @@ -354,8 +354,8 @@ static void rs_flush_buffer(struct tty_struct *tty)
>         wake_up_interruptible(&tty->write_wait);
> 
>         if ((tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
> -           tty->ldisc.write_wakeup)
> -               (tty->ldisc.write_wakeup)(tty);
> +           tty->ldisc.ops->write_wakeup)
> +               (tty->ldisc.ops->write_wakeup)(tty);

We have a tty_wakeup method, drivers shouldn't be poking around in
tty flags any more

> -       if (tty->ldisc.flush_buffer) tty->ldisc.flush_buffer(tty);
> +       if (tty->ldisc.ops->flush_buffer) tty->ldisc.ops->flush_buffer(tty);

And we have a method for that too 8)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/